DO NOT MERGE: Functional review #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting this into the main codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Ariel's last day as an intern at GenUI being Monday, October 3rd, 2022, he and I sat down in a pairing session to review the work here - including starting from a clean repo to a Teams integration.
Some minor tweaks are necessary, but this PR should not be merged until the code is cleaned up to address:
This needs to be tested with a Microsoft 365 Developer account as an example Teams app before considering this functionally complete. As of this moment - Tuesday, October 4th, 2022 - there is a known issue in the Microsoft 365 Developer Portal where sandboxes cannot be generated. Users are advised to check back in a few days.
Firebase project configuration should be environment variables
Resolve the issue where environment variables loaded properly for Ariel but not for Rob's environment. There is a hack in place to default to an explicit appId and appPassword as a temporary band-aid to get this functional.
Likely no need to log data received in the onValue function; though it's not a deal breaker in its current state