-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
digit-recognition frontend #3
base: master
Are you sure you want to change the base?
Conversation
8282859
to
6ccbbd6
Compare
6ccbbd6
to
a9d5431
Compare
…ation/gear.exe-dapps into vt-digit-recognition-frontend
…ation/gear.exe-dapps into vt-digit-recognition-frontend
…ation/gear.exe-dapps into vt-digit-recognition-frontend
"@": path.resolve(__dirname, "src"), | ||
}, | ||
}, | ||
plugins: [react(), svgr()], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add vite-plugin-checker
please to display TS and ESlint errors during development, otherwise a lot of things get missed.
/** | ||
* Hook that tracks the state of a CSS media query. | ||
*/ | ||
export function useMedia(query: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm against matching queries in JS, quite a lot of complexity, performance impact and sometimes unpredictable behavior. CSS media queries are much more reliable.
@@ -0,0 +1,15 @@ | |||
import type * as React from "react" | |||
|
|||
export function mergeRefs<T = any>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
|
||
function App() { | ||
const ethAccount = useAccount(); | ||
const isConnected = Boolean(ethAccount.chain); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should check if connected chain is the one we need.
No description provided.