Bug fixing for MrSteam

RUFF checks

README.md

@@ -281,6 +281,7 @@ https://www.gnu.org/licenses/gpl-3.0.html
   shared global config?
 - Expose the master timeouts as configurations and the ud timeouts as controls
 - Keep looking to see if there is a time sync mechanism
+- Use the config ver and status ver check in simulator to make sure partial block updates are acceptable
 
 ## Done/Fixed in 1.0.7
  - Move on with MrSteam device detection, it ought to load the facade cleanly now

src/geckolib/automation/async_facade.py

@@ -234,21 +234,27 @@ def _scan_outputs(self) -> None:
             self._sensors.extend(
                 [
                     GeckoSensor(
-                        self, "Mr.Steam On/Off", self._spa.accessors["UserMode"]
+                        self,
+                        "Mr.Steam On/Off",
+                        self._spa.accessors[GeckoConstants.KEY_MRSTEAM_USER_MODE],
                     ),
                     GeckoSensor(
-                        self, "Mr.Steam Aroma", self._spa.accessors["UserAroma"]
+                        self,
+                        "Mr.Steam Aroma",
+                        self._spa.accessors[GeckoConstants.KEY_MRSTEAM_USER_AROMA],
                     ),
                     GeckoSensor(
                         self,
                         "Mr.Steam Temperature",
-                        self._spa.accessors["UserSetpointG"],
-                        self._spa.accessors["TempUnits"],
+                        self._spa.accessors[GeckoConstants.KEY_MRSTEAM_USER_SETPOINT_G],
+                        self._spa.accessors[GeckoConstants.KEY_TEMP_UNITS],
                     ),
                     GeckoSensor(
                         self,
                         "Mr.Steam Runtime",
-                        self._spa.accessors["RemainingRuntime"],
+                        self._spa.accessors[
+                            GeckoConstants.KEY_MRSTEAM_REMAINING_RUNTIME
+                        ],
                     ),
                 ]
             )

src/geckolib/automation/watercare.py

@@ -6,12 +6,12 @@
 from typing import TYPE_CHECKING
 
 from geckolib.const import GeckoConstants
-from geckolib.driver import GeckoWatercareProtocolHandler
 
 from .base import GeckoAutomationFacadeBase
 
 if TYPE_CHECKING:
     from geckolib.automation.async_facade import GeckoAsyncFacade
+    from geckolib.driver import GeckoWatercareProtocolHandler
 
 _LOGGER = logging.getLogger(__name__)
 

src/geckolib/const.py

@@ -67,6 +67,11 @@ class GeckoConstants:
     KEY_LOCKMODE = "LockMode"
     KEY_STANDBY = "QuietState"
 
+    KEY_MRSTEAM_USER_MODE = "UserMode"
+    KEY_MRSTEAM_USER_AROMA = "UserAroma"
+    KEY_MRSTEAM_USER_SETPOINT_G = "UserSetpointG"
+    KEY_MRSTEAM_REMAINING_RUNTIME = "RemainingRuntime"
+
     KEY_USER_DEMAND_LIGHT = "UdLi"
 
     EXCEPTION_MESSAGE_NOT_WRITABLE = (

src/geckolib/driver/async_spastruct.py

@@ -287,6 +287,7 @@ def build_connections(self) -> None:
     #
     #   Accessory support
 
+    @property
     def is_mr_steam(self) -> bool:
         """Is this a MrSteam pack."""
         return self.plateform_key == "mrsteam"

src/geckolib/utils/cui/cui.py

@@ -211,7 +211,7 @@ def _spa_problem(self) -> None:
                 )
             )
 
-    def _build_facade_ui(self, _maxy: int, maxx: int) -> None:
+    def _build_facade_ui(self, _maxy: int, maxx: int) -> None:  # noqa: PLR0912
         if self.facade is None:
             return
         curx = 2
@@ -247,7 +247,8 @@ def _build_facade_ui(self, _maxy: int, maxx: int) -> None:
             self._lines.append("We have a Mr Steam unit")
             self._lines.append("")
 
-        self._lines.append(f"{self.facade.water_heater}")
+        if self.facade.water_heater.is_available:
+            self._lines.append(f"{self.facade.water_heater}")
         if self.facade.inmix.is_available:
             self._lines.extend(f"{zone}" for zone in self.facade.inmix.zones)
             if self.facade.inmix.syncro.is_available:

src/geckolib/utils/shell.py

@@ -11,7 +11,6 @@
 
 from geckolib import VERSION, GeckoConstants, GeckoPump
 from geckolib.async_spa_manager import GeckoAsyncSpaMan
-from geckolib.automation import inmix
 from geckolib.automation.base import GeckoAutomationBase, GeckoAutomationFacadeBase
 from geckolib.config import release_config_change_waiters
 from geckolib.driver.accessor import GeckoStructAccessor