Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common filesystem #929

Closed
wants to merge 6 commits into from
Closed

Use common filesystem #929

wants to merge 6 commits into from

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 1, 2022

🎉 New feature

Closes #

Summary

This deprecate's libsdformat's Filesystem.hh and uses the equivalent functions found in Ignition Common.

Test it

The tests should pass.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Nate Koenig added 5 commits March 30, 2022 11:28
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested review from azeey and scpeters as code owners April 1, 2022 00:31
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 1, 2022
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@mjcarroll
Copy link
Contributor

Is this supposed to be targeted to 12 or main?

@chapulina chapulina changed the base branch from sdf12 to main April 5, 2022 18:36
@chapulina chapulina added 🌱 garden Ignition Garden and removed 🏯 fortress Ignition Fortress labels Apr 5, 2022
@chapulina
Copy link
Contributor

Is this supposed to be targeted to 12 or main?

I retargeted it to main

@chapulina
Copy link
Contributor

I believe it was decided that we should go with std::filesystem, since Gazebo's filesystem is only a wrapper around that from Garden.

@mjcarroll
Copy link
Contributor

I believe it was decided that we should go with std::filesystem, since Gazebo's filesystem is only a wrapper around that from Garden.

That was my understanding as well, I'm going to close this.

@mjcarroll mjcarroll closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants