Add policy for handling CalculateInertial failures (backport #1543) #1546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Alternative to #1542
Summary
If
Geometry::CalculateInertial()
fails to calculate valid inertial values, the current behavior is to report aLINK_INERTIA_INVALID
error and write no inertial values. The changes in #1542 would changeMesh::CalculteInertial()
to return default inertial values by default if no valid values are found.This pull request adds a policy enum to
ParserConfig
to retain the current error behavior by default, but also provides an option to warn and use default inertial values when invalid inertial values are calculated.Draft PR until more testing is added
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.This is an automatic backport of pull request #1543 done by [Mergify](https://mergify.com).