check proper creation of EmbeddedSdf.cc

[efferre79]

Closes: #1535

🦟 Bug fix

Fixes #

Summary

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

[azeey]

LGTM! Thanks for the contribution!

Note that file(SIZE was added in 3.14 but the minimum CMake version in the sdf14 branch is 3.12, so we should not backport this PR. @efferre79 let me know if you want to work on a different approach. Otherwise, we'll merge this as is, but not backport to older versions.

[scpeters]

is there an easy way to reproduce this bug? I'd like to see what console output it gives

[azeey]

is there an easy way to reproduce this bug? I'd like to see what console output it gives

I just added an intentional error in embedSdf.py

-- Install prefix: /home/addisuzt/ws/ionic/install
Traceback (most recent call last):
  File "/home/addisuzt/ws/ionic/src/sdformat/sdf/embedSdf.py", line 13, in <module>
    intentional_error
NameError: name 'intentional_error' is not defined
CMake Error at sdf/CMakeLists.txt:28 (file):
  file SIZE requested of path that is not readable:

    /home/addisuzt/ws/ionic/build/sdformat15/src/EmbeddedSdf.cc


CMake Error at sdf/CMakeLists.txt:29 (if):
  if given arguments:

    "EQUAL" "0"

  Unknown arguments specified


-- Configuring incomplete, errors occurred!

[efferre79]

LGTM! Thanks for the contribution!

Note that file(SIZE was added in 3.14 but the minimum CMake version in the sdf14 branch is 3.12, so we should not backport this PR. @efferre79 let me know if you want to work on a different approach. Otherwise, we'll merge this as is, but not backport to older versions.

on my system cmake is 3.30.6 so I am not interested in finding a different approach

[scpeters]

thanks for the contribution!

[scpeters]

I had an idea for additional improvements to the error messaging, and opened #1549 with these changes. @efferre79 please take a look if you're interested