Merge sdf14 ➡️ main #1457
Merged
Merge sdf14 ➡️ main #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Currently errors are generated when adding an attribute containing an empty string to a <plugin> block or as a custom attribute. This adds failing tests to confirm the bug and fixes the errors in by setting `_required == 0` when calling Element::AddAttribute. This also changes Element::ToString to print empty custom attributes. Fixes #725. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Merge 12 -> 13
#1424) Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: youhy <haoyuan2019@outlook.com> Co-authored-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Merge 13 -> 14
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Merge 13 -> 14
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Update test to confirm that #54 is fixed. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Backport: Add cone shape to SDFormat spec (#1418) Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com> Co-authored-by: Steve Peters <computersthatmove@gmail.com>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* Prepare for 13.8.0 release Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Adds missing sdf::Errors structure as an option to report errors on SDF. Makes sure that no errors are printed and all are reported through the structure when using the functions that include it as parameter. --------- Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Marco A. Gutierrez <marco@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
The current pattern matches the following: "sdf", "sdf0", "sdf1", ..., "sdf8", "sdf9" of which "sdf" is incorrect, and only "sdf9" is currently supported. This updates the pattern to match single digits "sdf1" - "sdf9" and double digits "sdf10" to "sdf99". Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Merge sdf13 ➡️ sdf14
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
We don't use the latex output anywhere, but it brings in a big dependency when building documentation or deb packages. The class hierarchy is also not that useful since there is not much inheritance used in the codebase. This also brings the doxygen parameters of sdformat closer to other Gazebo libraries. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit 8e7b267)
ahcorde
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
sdf14➡️mainBranch comparison: main...sdf14
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)