Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space bots isr/pr spacecraft reversible motors #2790

Closed
wants to merge 38 commits into from
Closed

Space bots isr/pr spacecraft reversible motors #2790

wants to merge 38 commits into from

Conversation

andre-rebelo-teixeira
Copy link

🦟 Bug fix

Fixes #

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Closes #

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

➡️ Forward port

Port <FROM_BRANCH> to <TO_BRANCH>

Branch comparison: https://github.com/gazebosim//compare/<TO_BRANCH>...<FROM_BRANCH>

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎈 Release

Preparation for <X.Y.Z> release.

Comparison to <x.y.z>: https://github.com/gazebosim//compare/<LATEST_TAG_BRANCH>...<RELEASE_BRANCH>

Needed by <PR(s)>

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in gazebo-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Pedro-Roque and others added 30 commits June 4, 2024 17:49
@Pedro-Roque
feat: added support for spacecraft thrusters
f3421a2 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
rft: codechecked
b22c8b2 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
doc: adding basic tutorial with short description
24841e9 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
doc: improved comment regarding the method
9d88cdf 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
fix: naming on comment
3c802b5 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
fix: addressed request changes for PR
a8f08f1 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque @ahcorde
doc: image reference change on tutorials/spacecraft_thrusters.md
4e60a6f 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
feat: added world with spacecraft example and dart model
05d5a6d 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
rft: moved mesh to fuel
52c1505 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
fix: linting and dart version in SDF
dfa7fe1 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
feat: added world with spacecraft example and dart model
95a397b 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
rft: moved mesh to fuel
4e5dd59 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
fix: unmerged file
8168609 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
doc: fixed wrong doc instruction
727b4ee 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
feat: added world with spacecraft example and dart model
cd7d2a4 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
rft: moved mesh to fuel
1a02dec 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
fix: lint issue on plugin source file
13dd82a 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
fix: linting issues on tutorial file
bf7c966 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
fix: documentation and removed not used arguments
d4c7530 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
doc: removed trailing whitespaces
4689215 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
doc: fixed line lengths
95f5231 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
doc: ... and removing trailing spaces again ...
d48bcf1 
Signed-off-by: Pedro Roque <padr@kth.se>
@bperseghetti
Some suggested changes (#1)
6250a96 
* Use camel case and align to topic and actuator message convention.

Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>

* Cleanup tutorial to match other changes and follow other tutorial scope.

Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>

---------

Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
@Pedro-Roque
rft: fix building and cleaning unnecessary headers
0c458e1 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
feat: added 2D spacecraft simulation
11f4e42 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
doc: updated documentation for 2D spacecraft simulator
9bed3ec 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
fix: trailing whitespace
6ef6b60 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
add: unit test for spacecraft thrusters
d7e247f 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
fix: bug on target 0.0 duty cycle
dc2abc9 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
fix: linting
0a36b22 
Signed-off-by: Pedro Roque <padr@kth.se>
Pedro-Roque and others added 8 commits July 17, 2024 18:12
@Pedro-Roque
lint: shrank one line
d2db67c 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
test: enabling for windows
e3ad96f 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
revert: keep ignoring windows testing
c9678b5 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
fix: changed motor_speed to duty_cycle for clarity
3b5217c 
Signed-off-by: Pedro Roque <padr@kth.se>
@Pedro-Roque
Merge remote-tracking branch 'origin/gz-sim7' into pr-spacecraft-thru…
9127aef 
…sters
@andre-rebelo-teixeira
feat(ReversibleMultiCopterMotorModel): Created a simplistic model for…
ae04a1c 
… a reversible drone motor
@andre-rebelo-teixeira
fix(ReversibleMotor): Update to third order system to be closer to th…
b0b2bbf 
…e real model we have in the robot
@andre-rebelo-teixeira
Merge pull request #1 from gazebosim/gz-sim7
09e7dbb 
Merge upstream main branch into my work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll will be requested when the pull request is marked ready for review mjcarroll is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andre-rebelo-teixeira @Pedro-Roque @bperseghetti