New C4275 warnings on Windows from OgreUTFString

[chapulina]

Environment

• OS Version: Windows
• Source or binary build? Source, main branch

Description

• Expected behavior: No warnings on CI
• Actual behavior: 100 warnings on CI

Steps to reproduce

Run Windows CI.

Output

See for example:

https://build.osrfoundation.org/job/ign_rendering-pr-win/2552/msbuild/

non dll-interface class 'std::runtime_error' used as base for dll-interface class 'Ogre::UTFString::invalid_data' (compiling source file C:\Jenkins\workspace\ign_rendering-pr-win\ws\ign-rendering\ogre\src\OgreConversions.cc)

[chapulina]

• Fix Windows warnings #622

via

• Destroy root node and clean up sensor resources on exit #617

fixed the warnings for Fortress, but not for Citadel - that's been yellow since May:

https://build.osrfoundation.org/job/ign_rendering-ign-3-win/

I've removed the Windows check requirement for ign-rendering3 and updated

• Make CI checks required gazebo-tooling/release-tools#398

@Blast545 / @Crola1702 - this would be a good one to tackle soon

[Crola1702]

@mjcarroll I'm looking into this problem. I was checking this #617 PR and thinking about backporting just macros in the files.

Are you looking into this? Or, can I self assign this for the moment?

[mjcarroll]

I'm not currently looking at it, but it's in my queue. If you want to grab it, I would appreciate.

I think that the macros are exactly what is needed here.

[Crola1702]

This was fixed with: #707
It's working here: https://build.osrfoundation.org/job/ign_rendering-ign-3-win/80/msbuild/folder.702720613/#categoryContent
We can close this now.