Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of message headers #196

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Fix usage of message headers #196

merged 2 commits into from
Aug 31, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 31, 2022

🦟 Bug fix

Summary

This is needed to compile since gazebosim/gz-transport#315 was merged.

Also fixed a deprecation warning due to gazebosim/gz-sim#1352.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the bug Something isn't working label Aug 31, 2022
@chapulina chapulina requested a review from mjcarroll August 31, 2022 16:48
@chapulina chapulina requested a review from nkoenig as a code owner August 31, 2022 16:48
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 31, 2022
@chapulina chapulina changed the title Fix usage og message headers Fix usage of message headers Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #196 (d264b36) into gz-launch6 (178645f) will not change coverage.
The diff coverage is n/a.

❗ Current head d264b36 differs from pull request most recent head 5b807b2. Consider uploading reports for the commit 5b807b2 to get more accurate results

@@             Coverage Diff             @@
##           gz-launch6     #196   +/-   ##
===========================================
  Coverage       56.90%   56.90%           
===========================================
  Files               3        3           
  Lines             413      413           
===========================================
  Hits              235      235           
  Misses            178      178           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina enabled auto-merge (squash) August 31, 2022 17:41
@chapulina chapulina merged commit 9fe4564 into gz-launch6 Aug 31, 2022
@chapulina chapulina deleted the chapulina/6/msgs.hh branch August 31, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants