Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.xml and validation workflow #3

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

scpeters
Copy link
Member

🎉 New feature

Adds a package.xml file

Summary

I noticed that our Gazebo metapackages don't have package.xml files, but they easily could, so I added one for gz-jetty with @azeey as the maintainer.

Test it

  • Confirm that added workflow passes
  • Add gz-jetty to a colcon workspace with other jetty packages and confirm that colcon graph properly recognizes package order

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested review from azeey and mjcarroll January 27, 2025 22:01
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any objection to adding package.xml file here, but I also don't know if there are any advantages for doing so.

@scpeters
Copy link
Member Author

I don't have any objection to adding package.xml file here, but I also don't know if there are any advantages for doing so.

if we ever use bloom to generate packaging metadata from package.xml, it could be helpful. otherwise I think it just provides consistency with our other gz-* packages

@scpeters scpeters merged commit 9f2e1d1 into main Jan 28, 2025
2 checks passed
@scpeters scpeters deleted the scpeters/add_package_xml branch January 28, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants