Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable staging-fuel.ignitionrobotics.org test #257

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Jun 6, 2022

Summary

Disables tests being caused by #254.

Checklist

  • Signed all commits for DCO
  • Added (actually removed) tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 requested a review from nkoenig as a code owner June 6, 2022 19:04
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jun 6, 2022
@Blast545
Copy link
Contributor Author

Blast545 commented Jun 6, 2022

This should have green CI for Linux and MacOS before merging. Windows will be yellow with protobuf warnings.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ign-fuel-tools4@441c589). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             ign-fuel-tools4     #257   +/-   ##
==================================================
  Coverage                   ?   76.15%           
==================================================
  Files                      ?       19           
  Lines                      ?     2718           
  Branches                   ?        0           
==================================================
  Hits                       ?     2070           
  Misses                     ?      648           
  Partials                   ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 441c589...0f66985. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @nkoenig will work on a more permanent fix, for now disabling the tests so CI is 🟢 again!

@Blast545
Copy link
Contributor Author

Blast545 commented Jun 6, 2022

There's a remaining error on Windows. But it's not related to staging-fuel, so I'll merge this and open a PR with a fix or a ticket issue.

@Blast545 Blast545 merged commit 2010890 into ign-fuel-tools4 Jun 6, 2022
@Blast545 Blast545 deleted the blast545/disable_staging_tests branch June 6, 2022 21:35
@chapulina
Copy link
Contributor

Forward port to Fortress in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants