Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include chrono in Event.hh header #664

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Feb 28, 2025

🦟 Bug fix

Fixes the missing include of <chrono> in Event.hh that uses std::chrono.

Summary

<chrono> was not included in Event.hh, even if std::chrono was used there. Probably this went unnoticed due to transitive includes in the standard libraries, but in the new Visual Studio 17.13 this stopped working, probably due to a changes in the transitive includes. Anyhow, it make sense to add it to follow IWYU.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Silvio <silvio.traversaro@iit.it>
@ahcorde ahcorde merged commit 683493c into gazebosim:gz-common6 Feb 28, 2025
11 of 12 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Feb 28, 2025

https://github.com/Mergifyio gz-common5

Copy link

mergify bot commented Feb 28, 2025

gz -common5

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@ahcorde
Copy link
Contributor

ahcorde commented Feb 28, 2025

https://github.com/Mergifyio backport gz-common5

Copy link

mergify bot commented Feb 28, 2025

backport gz-common5

✅ Backports have been created

  • Backport to branch gz-common5 not needed, change already in branch gz-common5

@traversaro
Copy link
Contributor Author

https://github.com/Mergifyio backport gz-common5

Apparently the vcpkg team already did the fix in #655, it was simply not forward propagated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants