Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scape $USER in Dockerfile to avoid bash expansion #963

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Scape $USER in Dockerfile to avoid bash expansion #963

merged 2 commits into from
Jun 29, 2023

Conversation

j-rivero
Copy link
Contributor

Part of #923 efforts. Should have no change in behavior.

Tested:

  • Build Status
  • Build Status

j-rivero added 2 commits June 28, 2023 16:41
@j-rivero
Change Dockerfile MAINTAINER command (deprecated) in favour of LABEL
6f202ed 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Scape $USER in Dockerfile to avoid bash expansion
273f60d 
Keep Dockerfile variables in placce. Should help with the local
reproducibility.

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero merged commit d924412 into master Jun 29, 2023
@j-rivero j-rivero deleted the jrivero/docker_improvements branch June 29, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j-rivero