Cleanup: remove unused sdformat/rndf scripts #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
|
@j-rivero I see: https://build.osrfoundation.org/job/sdformat-ci-main-noble-amd64/73/consoleFull#778115112a7262995-c11a-4bcd-8780-7a1be73bc65d I think it Also it is happening on windows jobs: https://build.osrfoundation.org/job/sdformat-main-clowin/6/console |
Wow. So the CI should take care of this, if I run it locally: But it does no return error :( Let me fix the CI and the revert the scripts back. |
I already sent the PR to bring the scripts back: #1266 |
j-rivero
added a commit
that referenced
this pull request
Feb 21, 2025
* Restore sdformat scripts Needed for: * https://build.osrfoundation.org/job/sdformat-ci-main-noble-amd64/73/ * https://build.osrfoundation.org/job/sdformat-main-clowin/6/console Signed-off-by: Cristóbal Arroyo <cristobal.arroyo@ekumenlabs.com> * Restore sdformat hook Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com> * Do not support old sdformats Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com> --------- Signed-off-by: Cristóbal Arroyo <cristobal.arroyo@ekumenlabs.com> Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Jose Luis Rivero <jrivero@honurobotics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing obsolete files. Can not find references to them in the source code and there is a check in CI to look for existing scripts referenced in the XML configurations.