Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libwebsockets-dev dependency #4

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Add libwebsockets-dev dependency #4

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cafe0d0
add libwebsockets-dev dependency
iche033 Feb 20, 2025
f97c648
add libwebsockets-dev to plugins
iche033 Feb 24, 2025
d438ccd
Revert "add libwebsockets-dev to plugins"
j-rivero Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ubuntu/debian/control
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Build-Depends: cmake,
doxygen,
dh-python,
libtinyxml2-dev,
libwebsockets-dev,
libgz-tools2-dev,
libgz-cmake4-dev,
libgz-common6-av-dev,
Expand Down Expand Up @@ -81,6 +82,7 @@ Package: libgz-sim10-dev
Architecture: any
Section: libdevel
Depends: libtinyxml2-dev,
libwebsockets-dev,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only being used in the development package? or should we expect to see it in runtime use cases even if no development tool is installed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I copied from gz-launch which only adds it to the libgz-launch9-dev package. However, I am linking to websocket shared library in the websocket server system's CMakeLists.txt here. So I think I should add this to libgz-sim10-plugins right?

Added in f97c648. Let me know if that's not correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I copied from gz-launch which only adds it to the libgz-launch9-dev package. However, I am linking to websocket shared library in the websocket server system's CMakeLists.txt here. So I think I should add this to libgz-sim10-plugins right?

Ops sorry, I was not correct on the coment. The runtime dependencies should be handled by ${shlibs:Depends} in the binary runtime package so we should be covered and the gz-launch packaging is right.

Going to revert the last commit and merge since it was fine at the beginning. Sorry for the noise Ian.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah understood, thanks!

libgz-tools2-dev,
libgz-cmake4-dev,
libgz-common6-av-dev,
Expand Down