-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component hangs at loadingComponent
after Jitsi update (meet.jit.si, alpha.jitsi.net and further recent deployments)
#14
Comments
Update: This is due to the "Join Meeting" preparation page that's now displayed on meet.jit.si – it prevents the loaded flag to be set to true, so the API iframe is css-hidden and the loadingComponent is not removed from the DOM. |
@otrsk were you able to find a workaround? Is it possible to manually set the loaded flag to true? |
@e18r You could edit the node_module directly to not show the |
@otrsk thank you so much. I just temporarily fixed the bug in my app by switching to the domain I'm gonna edit the node_module as you suggest in order not to depend on 8x8 upgrading to the latest version, which they could do very soon. However, I'd also like to understand this issue better and, why not, maybe even contribute a PR to this useful repo. Do you have any idea where's the upstream code that is causing this? Looking at the commit history of Jitsi Meet doesn't seem to give any answers. |
@e18r I've only had time for a quick glance at the code, unfortunately. However, I've seen the "call preparation" (not sure what the real name is) feature deployed at e.g. https://alpha.jitsi.net/ at least a few weeks ago already. So this might be a config change. I didn't find a flag to disable the "call preparation" feature in the iframe API, but the documentation seemed to be outdated, so you might have more luck looking at the code! |
@otrsk @e18r https://codesandbox.io/s/youthful-cache-z5g76?file=/src/App.js |
@dacopan amazing, thanks! For Typescript, combined with adding |
@gatteo This option would need to always be set to false for the current |
PS: For Typescript, you can enforce the untyped flag this way without having to touch the node_module: |
@dacopan mil gracias hermano! |
Thanks a lot @dacopan @otrsk |
@dacopan @otrsk Great! 👏 |
@gatteo Please include this in the readme file. It would help someone because at first even I thought the library is broken. |
Solving missing type error as described in gatteo#14 (comment)
It seems like an update rolled out to e.g. meet.jit.si in the last 12 hours broke the react-jitsi component. It never loads, keeping displaying the
loadingComponent
. No error or warning messages are logged to the console. It's fully functional again if I set thedomain
property to a less recent Jitsi deployment, e. g. 8x8.vc.The text was updated successfully, but these errors were encountered: