Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent default values for exchange fees ? #42

Open
asmodehn opened this issue Jul 3, 2019 · 2 comments
Open

Consistent default values for exchange fees ? #42

asmodehn opened this issue Jul 3, 2019 · 2 comments

Comments

@asmodehn
Copy link
Contributor

asmodehn commented Jul 3, 2019

Having a look at kraken_btc_usd and kraken_btc_eur the fees are configured for different type of users...

Ideally we should have the default values matching the setup of a new user of an exchange.
We can probably not enforce that they always match what the exchange fees actually are, but we probably can :

  • centralize some of the exchange configuration (it's not related with the traded currency pair for example), to avoid inconsistent changes in multiple places.
  • keep reference links around in the source, and rely on a developer modifying the default values when the exchange happens to change its fees policy.
  • Builtin strategy configuration autocreate ? #41 so that "advanced" user can easily change their personal fee via configuration, once they have traded enough to have their fees decreased by the exchange.
@garethdmm
Copy link
Owner

I'd love it if someone could do a exchange fee audit on the exchange library, as well as keeping the reference links nearby in the code. Keeping tabs on 20+ pairs as their fee brackets change over time is difficult but would get easier if we had multiple eyes on it, or had multiple people with more focused areas of responsibility.

@itali43
Copy link
Contributor

itali43 commented Feb 1, 2020

submitted a pull request (#80 ) that addresses "keep reference links around in the source, and rely on a developer modifying the default values when the exchange happens to change its fees policy."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants