Fix Deployment in Garden Runtime Cluster #1215
Open
+42
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `StorageClass` must not be considered if deployed by the `gardener-operator` to the runtime cluster. Otherwise different extensions fight against creating the same resource in the cluster.
The default values shouldn't anticipate if the extension is deployed to a seed or garden runtime cluster. Dropping the default values makes this chart handling less error-prone.
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area delivery
/kind bug
/platform aws
What this PR does / why we need it:
This PR mainly fixes an issue that occurred when deploying the extension as an Gardener Operator extension to the garden runtime cluster.
Because of the seed default values, it unconditionally deployed the
gardener.cloud-faststorage class which is not only unexpected if the runtime garden is no AWS cluster, but caused race conditions with other provider extensions in the very same cluster (see commit descriptions).Special notes for your reviewer:
/cc @MartinWeindel
I plan to back-port the fix by cherry-picking commit 8bcae9a.
Similar PRs are expected on remaining provider extensions.
Release note: