chore: Cleanup deprecated label approach #1213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/dev-productivity
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
marc1404
commented
Feb 5, 2025
| @@ -94,10 +93,6 @@ func (e *ensurer) EnsureKubeAPIServerDeployment(ctx context.Context, gctx gconte | |||
| template := &newObj.Spec.Template | |||
| ps := &template.Spec | |||
|
|
|||
| // TODO: This label approach is deprecated and no longer needed in the future. Remove it as soon as gardener/gardener@v1.75 has been released. | |||
There was a problem hiding this comment.
The latest gardener/gardener release at the time of writing is v1.111.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind cleanup
/platform aws
What this PR does / why we need it:
This PR cleans up the deprecated label approach for defining network policies.
The first of these labels was introduced here:
9fbf711
See the corresponding PR for more context:
gardener/gardener#7907
Which issue(s) this PR fixes:
n.a.
Special notes for your reviewer:
Uncertainty:
I can find the annotation that replaces the deprecated label
networking.resources.gardener.cloud/to-csi-snapshot-validation-tcp-443=allowed:gardener-extension-provider-aws/charts/internal/seed-controlplane/charts/csi-driver-controller/templates/csi-snapshot-validation-webhook-service.yaml
Line 7 in fe0e6d9
I cannot find the same for
networking.resources.gardener.cloud/to-aws-load-balancer-controller-webhook-service-tcp-9443=allowed. Do we need to add this port to one of the existing annotations?Release note: