Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Cleanup overdue TODOs #1212

Closed
wants to merge 0 commits into from
Closed

chore: Cleanup overdue TODOs #1212

wants to merge 0 commits into from

Conversation

marc1404
Copy link
Member

@marc1404 marc1404 commented Feb 4, 2025 •
edited
Loading

How to categorize this PR?

/area dev-productivity
/kind cleanup
/platform aws

What this PR does / why we need it:

🚧

Which issue(s) this PR fixes:

n.a.

Special notes for your reviewer:

n.a.

Release note:

NONE

@marc1404 marc1404 requested review from a team as code owners February 4, 2025 14:50
@gardener-robot gardener-robot added needs/review Needs review area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 4, 2025
@marc1404 marc1404 force-pushed the chore/cleanup-overdue-todos branch from 3b4fd56 to 44579c2 Compare February 4, 2025 14:51
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 4, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 4, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 4, 2025
@marc1404 marc1404 changed the title chore: Cleanup overdue TODO chore: Cleanup overdue TODOs Feb 4, 2025
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Feb 4, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 4, 2025
@gardener-robot gardener-robot removed the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Feb 4, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 4, 2025
@marc1404 marc1404 marked this pull request as draft February 4, 2025 16:27
@marc1404
Copy link
Member Author

marc1404 commented Feb 4, 2025

/hold

I need to recheck what helmchart values should be kept and what should be removed.

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Feb 4, 2025
@marc1404 marc1404 force-pushed the chore/cleanup-overdue-todos branch from b2b7301 to 0c3607d Compare February 5, 2025 16:24
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 5, 2025
@marc1404 marc1404 closed this Feb 5, 2025
@marc1404 marc1404 force-pushed the chore/cleanup-overdue-todos branch from 0c3607d to cc87b60 Compare February 5, 2025 16:37
@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 5, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 5, 2025
@gardener-robot gardener-robot removed the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/aws Amazon web services platform/infrastructure reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marc1404 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot