Skip to content

Commit

Permalink
Use ipv6 CIDR only as ID for IPv6 only subnets. (#1158) (#1163)
Browse files Browse the repository at this point in the history
Using IPv6 CIDR in ID string will break the migration of subnets from
IPv4 to dual-stack. Due to the different ID subnets would be deleted and
crated again. This already breaks the migration of IPv4 shoots to shoots
wiht dual-stack ingress.

Co-authored-by: Axel Siebenborn <axel.siebenborn@sap.com>
  • Loading branch information
AndreasBurger and axel7born authored Dec 6, 2024
1 parent ce8ed33 commit f25161e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/controller/infrastructure/infraflow/reconcile.go
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ func (c *FlowContext) ensureZones(ctx context.Context) error {
return err
}
toBeDeleted, toBeCreated, toBeChecked := diffByID(desired, current, func(item *awsclient.Subnet) string {
if item.Ipv6CidrBlocks != nil {
if item.Ipv6CidrBlocks != nil && item.CidrBlock == "" {
return item.AvailabilityZone + "-" + item.Ipv6CidrBlocks[0]
}
return item.AvailabilityZone + "-" + item.CidrBlock
Expand Down

0 comments on commit f25161e

Please sign in to comment.