Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Spectator Sign #731

Open
nicholasleejy opened this issue Apr 24, 2022 · 2 comments
Open

Feature Request: Spectator Sign #731

nicholasleejy opened this issue Apr 24, 2022 · 2 comments
Labels
area/sessions Related to how arena sessions run, e.g. wave setup, the lobby, spectating, event isolation, etc. type/enhancement New or improved feature.

Comments

@nicholasleejy
Copy link

Short description
A sign that allows you to spectate the arena, instead of using the command /ma spec

Implementation details
Similar to how the join sign works, the player can click on the sign of a running arena to teleport to the lobby as a spectator, exactly like how the "/ma spec" command functions.

Possible methods:

  • Either create another sign template, like the join/leave/info signs
  • Modify how the "join" sign functions, where if the arena is already running, the "join" sign will teleport you to the arena lobby/spectator area
@garbagemule garbagemule added type/enhancement New or improved feature. area/sessions Related to how arena sessions run, e.g. wave setup, the lobby, spectating, event isolation, etc. labels Apr 24, 2022
@garbagemule
Copy link
Owner

Not a bad idea.

I think I originally omitted the spectate behavior exactly because I didn't feel up to the task of deciding between an "overloaded" join behavior or separate join and spectate behaviors. I don't think there's anything particularly difficult about either approach.

  • A dedicated spectate sign would make it easier to distinguish between actions. Are you trying to join or spectate - you must choose. It would possibly require two signs everywhere you have a join sign, though.
  • On the other hand, an overloaded join sign would reduce the amount of signs needed and remove the choice from the player. It does mean you would have to wait until the arena begins to spectate it if you just want to spectate. It sacrifices some flexibility and predictability for convenience.

I don't think having both is a good idea, because it would mean the spectate sign only satisfies the aforementioned edge case of wanting to spectate before an arena starts. I also think overloaded join signs are a bit of a stretch in terms of consistency, because it means it will behave differently from the join command. We could opt to overload both, of course.

There's a third option where overloaded join signs are a setting. I don't really like that idea, mostly because it introduces extra logic and having to pass settings around everywhere, but also because the config-file is already pretty bloated.

@garbagemule garbagemule added the blocked/feedback Awaiting feedback or input from community. label May 28, 2022
@XBH3Bandit
Copy link

I personally would be happy with having another sign template for spectate. I feel as though to the player it's pretty self explanatory, and would be an easy and quick way of implementing it. Having 2 signs isn't particularly a detriment to most server developers, myself included, and I'd actually already accommodated for it in my build, as to me it made the most sense for that to be the functionality.

Copied here from discord on Garbagemule's instruction

@garbagemule garbagemule removed the blocked/feedback Awaiting feedback or input from community. label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sessions Related to how arena sessions run, e.g. wave setup, the lobby, spectating, event isolation, etc. type/enhancement New or improved feature.
Projects
None yet
Development

No branches or pull requests

3 participants