Merge pull request #3 from galihrivanto/investigate-race

Use better synchronization between command

action.go

@@ -110,7 +110,7 @@ func FileOpen(filePath string) string {
 
 // FileClose .
 func FileClose() string {
-	return "file-close:"
+	return "file-close"
 }
 
 // SelectAll .
@@ -144,15 +144,15 @@ func SelectClear() string {
 }
 
 // InvertOption define option when invert selection
-type InvertOption string 
+type InvertOption string
 
 // invert selection option
 const (
-	InvertOptionAll InvertOption = "all"
-	InvertOptionLayers = "layers"
-	InvertOptionNoLayers = "no-layers"
-	InvertOptionGroup = "group"
-	InvertOptionNoGroup = "no-group"
+	InvertOptionAll      InvertOption = "all"
+	InvertOptionLayers                = "layers"
+	InvertOptionNoLayers              = "no-layers"
+	InvertOptionGroup                 = "group"
+	InvertOptionNoGroup               = "no-group"
 )
 
 // SelectInvert .
@@ -164,3 +164,8 @@ func SelectInvert(option InvertOption) string {
 func SelectList() string {
 	return "select-list"
 }
+
+// Version print inksscape version and return
+func Version() string {
+	return "inkscape-version"
+}

cmd/svg2pdf/main.go

@@ -11,6 +11,7 @@ import (
 var (
 	svgInput  string
 	pdfOutput string
+	verbose   bool
 )
 
 func handleErr(err error) {
@@ -23,14 +24,16 @@ func handleErr(err error) {
 func main() {
 	flag.StringVar(&svgInput, "input", "", "svg input")
 	flag.StringVar(&pdfOutput, "output", "result.pdf", "pdf output")
+	flag.BoolVar(&verbose, "verbose", false, "verbose output")
 	flag.Parse()
 
 	if svgInput == "" {
 		fmt.Println("svg input is missing")
 		os.Exit(1)
 	}
 
-	proxy := inkscape.NewProxy(inkscape.Verbose(true))
+	proxy := inkscape.NewProxy(inkscape.Verbose(verbose))
+
 	err := proxy.Run()
 	handleErr(err)
 	defer proxy.Close()

option.go

@@ -13,6 +13,9 @@ type Options struct {
 	// maximum retry attempt
 	maxRetry int
 
+	// maximum command queue size
+	commandQueueLength int
+
 	// set verbosity
 	verbose bool
 }
@@ -33,6 +36,13 @@ func MaxRetry(retry int) Option {
 	}
 }
 
+// CommandQueueLength override maximum command queue size
+func CommandQueueLength(length int) Option {
+	return func(o *Options) {
+		o.commandQueueLength = length
+	}
+}
+
 // Verbose override log verbosity
 // useful for debugging
 func Verbose(verbose bool) Option {