Provide filling support for conics #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match the filling and drawing behavior of Cinderella exemplified by eval_helper.drawpolygon, this changes eval_helper.drawconic to csctx.fill() if Render2D.fillColor is set and then csctx.stroke() the curve without the boundary segments if Render2D.lsize is not zero. Also fixed eval_helper.drawpolygon to not csctx.stroke() if Render2D.lsize is zero since otherwise path is drawn.
Changes conic elements to use new conicDefault insead of lineDefault. conicDefault is based on polygonDefault and differs by setting el.filled to false instead of true.
This changes drawgeoconic to also pass fillalpha and fillcolor values in the modifs dictionary.
Added fillcolor and fillalpha so that they are included in the Co element's appearance. An appearance section has also been added so that the Co element's appearance can be easily manipulated. The sameLines example test for being able to display two parallel lines with no separation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes support using
eval_helper.drawconicto handle filling of conics. 63_Conic.html now has an appearance manipulation section to demonstrate this.