Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 상품 랭킹 로직 수정 #21

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

Go-Jaecheol
Copy link
Contributor

Issue

✨ 구현한 기능

  • 상품 랭킹 로직에서 기간(2주) 조건 삭제
@Query("SELECT new com.funeat.product.dto.ProductReviewCountDto(p, COUNT(r.id)) "
          + "FROM Product p "
          + "LEFT JOIN Review r ON r.product.id = p.id "
          + "WHERE p.averageRating > 3.0 "
          + "GROUP BY p.id")
List<ProductReviewCountDto> findAllByAverageRatingGreaterThan3();
# 삭제된 구문
AND r.createdAt BETWEEN :startDateTime AND :endDateTime

📢 논의하고 싶은 내용

X

🎸 기타

X

⏰ 일정

  • 추정 시간 : 15min
  • 걸린 시간 : 10min

Copy link

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit ffde52f. ± Comparison against base commit 9f2b410.

Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기간 관련된 로직만 싹 빠졌네요
LGTM ~

@Go-Jaecheol Go-Jaecheol merged commit 4ca009e into develop Feb 19, 2024
3 checks passed
@Go-Jaecheol Go-Jaecheol deleted the feat/issue-20 branch February 19, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

상품 랭킹 로직 수정
2 participants