-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _cat_file #45
Add _cat_file #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kephale ! Looks good, I think someone else will also take a look and merge. A few comments. Please take a look.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 94.00% 94.10% +0.10%
==========================================
Files 13 13
Lines 701 713 +12
==========================================
+ Hits 659 671 +12
Misses 42 42 ☔ View full report in Codecov by Sentry. |
@martindurant @efiop PTAL and merge if it looks good (I don't have access to this repo). |
LGTM @efiop , what are your plans for maintenance of this repo? Are you still available for making releases? |
@martindurant I've set up everything in the past to work even if I get hit by a bus :) Just for the record, one could just go to https://github.com/fsspec/sshfs/releases and click release, gha will do its magic 🙂 Triggered 2024.4.0 for now. As to maintaining, I am keeping an eye, but obviously no promises on the reaction time. |
Also added @shcheklein to admins here. |
Howdy folks, sshfs is amazing. Thank you for everything!
I was trying to use it for remote visualization of zarr images. This required support for
_cat_file
. This PR provides a_cat_file
implementation.