Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _cat_file #45

Merged
merged 6 commits into from
Apr 21, 2024
Merged

Add _cat_file #45

merged 6 commits into from
Apr 21, 2024

Conversation

kephale
Copy link
Contributor

@kephale kephale commented Apr 19, 2024

Howdy folks, sshfs is amazing. Thank you for everything!

I was trying to use it for remote visualization of zarr images. This required support for _cat_file. This PR provides a _cat_file implementation.

Copy link
Collaborator

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kephale ! Looks good, I think someone else will also take a look and merge. A few comments. Please take a look.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (c127831) to head (607ce56).

❗ Current head 607ce56 differs from pull request most recent head 8202cf1. Consider uploading reports for the commit 8202cf1 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   94.00%   94.10%   +0.10%     
==========================================
  Files          13       13              
  Lines         701      713      +12     
==========================================
+ Hits          659      671      +12     
  Misses         42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shcheklein
Copy link
Collaborator

@martindurant @efiop PTAL and merge if it looks good (I don't have access to this repo).

@martindurant
Copy link
Member

LGTM

@efiop , what are your plans for maintenance of this repo? Are you still available for making releases?

@martindurant martindurant merged commit 79f7661 into fsspec:main Apr 21, 2024
11 checks passed
@efiop
Copy link
Member

efiop commented Apr 21, 2024

@martindurant I've set up everything in the past to work even if I get hit by a bus :) Just for the record, one could just go to https://github.com/fsspec/sshfs/releases and click release, gha will do its magic 🙂 Triggered 2024.4.0 for now. As to maintaining, I am keeping an eye, but obviously no promises on the reaction time.

@efiop
Copy link
Member

efiop commented Apr 22, 2024

Also added @shcheklein to admins here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants