Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oxpecker support #477

Merged
merged 8 commits into from
Sep 1, 2024
Merged

Oxpecker support #477

merged 8 commits into from
Sep 1, 2024

Conversation

xperiandri
Copy link
Collaborator

No description provided.

@xperiandri xperiandri changed the title Implemented Oxpecker support Oxpecker support Apr 10, 2024
@xperiandri xperiandri force-pushed the Oxpecker branch 2 times, most recently from bd15cc6 to 15de2ce Compare April 10, 2024 23:55
@xperiandri xperiandri requested a review from valbers April 11, 2024 19:14
valbers
valbers requested changes Apr 13, 2024
View reviewed changes
Copy link
Collaborator

@valbers valbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

.github/workflows/publish_ci.yml Outdated Show resolved Hide resolved
src/FSharp.Data.GraphQL.Server.Giraffe/FSharp.Data.GraphQL.Server.Giraffe.fsproj Outdated Show resolved Hide resolved
src/FSharp.Data.GraphQL.Server.Oxpecker/FSharp.Data.GraphQL.Server.Oxpecker.fsproj Outdated Show resolved Hide resolved
src/FSharp.Data.GraphQL.Server.Oxpecker/HttpEndpoints.fs Outdated Show resolved Hide resolved
src/FSharp.Data.GraphQL.Server/Ast.fs Show resolved Hide resolved
@xperiandri xperiandri force-pushed the Oxpecker branch 2 times, most recently from 84d7327 to fa5baf0 Compare May 7, 2024 23:23
@xperiandri xperiandri marked this pull request as ready for review July 7, 2024 23:04
@xperiandri xperiandri requested a review from valbers July 7, 2024 23:04
@xperiandri
Copy link
Collaborator Author

@valbers, PR is ready for review
@njlr please review too

valbers
valbers previously requested changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@valbers valbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my remark about the naming of the class.

src/FSharp.Data.GraphQL.Server.AspNetCore/GraphQLRequest.fs Outdated Show resolved Hide resolved
@xperiandri xperiandri enabled auto-merge August 31, 2024 14:22
@xperiandri xperiandri requested a review from valbers August 31, 2024 14:22
@xperiandri xperiandri dismissed valbers’s stale review September 1, 2024 10:46

Addressed suggesstions

@xperiandri xperiandri disabled auto-merge September 1, 2024 10:49
@xperiandri xperiandri merged commit ab9a7a0 into dev Sep 1, 2024
3 checks passed
@xperiandri xperiandri deleted the Oxpecker branch September 1, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juriyx Juriyx Juriyx approved these changes

@valbers valbers Awaiting requested review from valbers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xperiandri @Juriyx @valbers