feat(BEAM): Add support for Erlang, Elixir, and Gleam comments #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikofernandez
changed the title
|
Thanks @maennchen for reminding me of Erlang's lexer and parser generators, which are now included in the PR :) |
kikofernandez
force-pushed
the
feature/erlang-elixir-gleam-comment
branch
from
6489b9c to
977d112
Compare
6 tasks
floriansnow
reviewed
Feb 3, 2025
kikofernandez
force-pushed
the
feature/erlang-elixir-gleam-comment
branch
from
977d112 to
e034c08
Compare
Elixir uses the same single line comment as Python, so we refactor the code and make Elxir to point to the `PythonCommentStyle` class comment style.
Gleam can reuse most of the CppSingleCommentStyle. CppSingleCommentStyle lacks SHEBANG, so we add them to Gleam's `GleamCommentStyle` subtype.
adds to `CppSingleCommentStyle` a shebangs for languages that use this style and allow shebangs, i.e., Gleam.
kikofernandez
force-pushed
the
feature/erlang-elixir-gleam-comment
branch
from
17de383 to
819012e
Compare
|
Is there anything else that I can help with to get support for Erlang/Elixir/Gleam? |
|
Let me know if there is anything else I need to fix :) |
|
Thanks @floriansnow for your guidance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for comments for the most used BEAM languages:
Erlang
Elixir
Gleam
Added a change log entry in
changelog.d/<directory>/.Added self to copyright blurb of touched files.
Added self to
AUTHORS.rst.My changes do not contradict
the current specification.
I agree to license my contribution under the licenses indicated in the
changed files.