Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BEAM): Add support for Erlang, Elixir, and Gleam comments #1117

Merged

Conversation

kikofernandez
Copy link
Contributor

Adds support for comments for the most used BEAM languages:

  • Erlang

  • Elixir

  • Gleam

  • Added a change log entry in changelog.d/<directory>/.

  • Added self to copyright blurb of touched files.

  • Added self to AUTHORS.rst.

  • My changes do not contradict
    the current specification.

  • I agree to license my contribution under the licenses indicated in the
    changed files.

@kikofernandez kikofernandez changed the title Feature/erlang elixir gleam comment feat(BEAM): Add support for Erlang, Elixir, and Gleam comments Dec 20, 2024
@kikofernandez
Copy link
Contributor Author

Thanks @maennchen for reminding me of Erlang's lexer and parser generators, which are now included in the PR :)

@kikofernandez kikofernandez force-pushed the feature/erlang-elixir-gleam-comment branch from 977d112 to e034c08 Compare February 3, 2025 20:53
Elixir uses the same single line comment as Python, so we refactor the
code and make Elxir to point to the `PythonCommentStyle` class comment style.
Gleam can reuse most of the CppSingleCommentStyle. CppSingleCommentStyle
lacks SHEBANG, so we add them to Gleam's `GleamCommentStyle` subtype.
adds to `CppSingleCommentStyle` a shebangs for languages that use this
style and allow shebangs, i.e., Gleam.
@kikofernandez kikofernandez force-pushed the feature/erlang-elixir-gleam-comment branch from 17de383 to 819012e Compare February 24, 2025 08:56
@kikofernandez
Copy link
Contributor Author

Is there anything else that I can help with to get support for Erlang/Elixir/Gleam?
Thanks!

@kikofernandez
Copy link
Contributor Author

Let me know if there is anything else I need to fix :)

@floriansnow floriansnow merged commit db6abab into fsfe:main Mar 13, 2025
15 checks passed
@kikofernandez
Copy link
Contributor Author

Thanks @floriansnow for your guidance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants