From 26698032e06416a27259553c173e4645c7677857 Mon Sep 17 00:00:00 2001 From: Jeremy Bokobza Date: Thu, 19 Dec 2024 16:34:52 +0000 Subject: [PATCH] Fix preloaded pool size (#19) * chore: rename blocks_preload_pool_size to preload_pool_size for consistency * chore: rename preload_pool_size to blocks_preload_pool_size for consistency * deprecate preload_pool_size and introduce block_preload_pool_size with warning * fix: set default value for preload_pool_size in LakeConfig * chore: warn user only if he provided `preload_pool_size` attribute --------- Co-authored-by: Ivan Frolov --- src/near_lake_framework/__init__.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/near_lake_framework/__init__.py b/src/near_lake_framework/__init__.py index af47441..e193a6d 100644 --- a/src/near_lake_framework/__init__.py +++ b/src/near_lake_framework/__init__.py @@ -48,7 +48,7 @@ class LakeConfig: aws_access_key_id: str aws_secret_key: str start_block_height: near_primitives.BlockHeight - blocks_preload_pool_size: int = 200 + blocks_preload_pool_size: int def __init__( # pylint: disable=too-many-arguments self, @@ -56,8 +56,15 @@ def __init__( # pylint: disable=too-many-arguments aws_access_key_id: str, aws_secret_key: str, start_block_height: near_primitives.BlockHeight, - preload_pool_size: int = 200, + preload_pool_size: None = None, + block_preload_pool_size: int = 200, ): + if preload_pool_size: + logger.warning( + "The 'preload_pool_size' argument is not used and will be deprecated in a " + "future release. Use 'blocks_preload_pool_size' instead." + ) + # These are entirely determined by Network. self.s3_bucket_name = f"near-lake-data-{network.value}" self.s3_region_name = "eu-central-1" @@ -65,7 +72,7 @@ def __init__( # pylint: disable=too-many-arguments self.aws_access_key_id = aws_access_key_id self.aws_secret_key = aws_secret_key self.start_block_height = start_block_height - self.preload_pool_size = preload_pool_size + self.blocks_preload_pool_size = block_preload_pool_size async def start(config: LakeConfig, streamer_messages_queue: asyncio.Queue):