Skip to content

Commit

Permalink
Fix preloaded pool size (#19)
Browse files Browse the repository at this point in the history
* chore: rename blocks_preload_pool_size to preload_pool_size for consistency

* chore: rename preload_pool_size to blocks_preload_pool_size for consistency

* deprecate preload_pool_size and introduce block_preload_pool_size with warning

* fix: set default value for preload_pool_size in LakeConfig

* chore: warn user only if he provided `preload_pool_size` attribute

---------

Co-authored-by: Ivan Frolov <frolvanya@gmail.com>
  • Loading branch information
bokobza and frolvanya authored Dec 19, 2024
1 parent 793eec8 commit 2669803
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions src/near_lake_framework/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,24 +48,31 @@ class LakeConfig:
aws_access_key_id: str
aws_secret_key: str
start_block_height: near_primitives.BlockHeight
blocks_preload_pool_size: int = 200
blocks_preload_pool_size: int

def __init__( # pylint: disable=too-many-arguments
self,
network: Network,
aws_access_key_id: str,
aws_secret_key: str,
start_block_height: near_primitives.BlockHeight,
preload_pool_size: int = 200,
preload_pool_size: None = None,
block_preload_pool_size: int = 200,
):
if preload_pool_size:
logger.warning(
"The 'preload_pool_size' argument is not used and will be deprecated in a "
"future release. Use 'blocks_preload_pool_size' instead."
)

# These are entirely determined by Network.
self.s3_bucket_name = f"near-lake-data-{network.value}"
self.s3_region_name = "eu-central-1"

self.aws_access_key_id = aws_access_key_id
self.aws_secret_key = aws_secret_key
self.start_block_height = start_block_height
self.preload_pool_size = preload_pool_size
self.blocks_preload_pool_size = block_preload_pool_size


async def start(config: LakeConfig, streamer_messages_queue: asyncio.Queue):
Expand Down

0 comments on commit 2669803

Please sign in to comment.