Use maybe_extract_from_apk for Gadget files #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergesh
force-pushed
the
unzip-gadget-files-android
branch
3 times, most recently
from
880f290 to
be77e58
Compare
oleavr
requested changes
Sep 13, 2024
|
I wasn't sure how to go about it without duplication of the code, care to point me in the right direction? |
gergesh
force-pushed
the
unzip-gadget-files-android
branch
from
be77e58 to
b4c0ed4
Compare
oleavr
force-pushed
the
unzip-gadget-files-android
branch
from
b4c0ed4 to
7c21c4c
Compare
Just pushed a rough attempt at it. Sorry it took me so long to get to this. Haven't tested the code yet, but it should go something like this. The idea is that once (minimal) minizip-ng Vala bindings are in place, the duplication needed is so minuscule that it's acceptable to duplicate the logic. |
On Android, when apps have `extractNativeLibs` set to `false`, the configuration and potentially script files for frida-gadget are not extracted and cannot be read from the filesystem. Co-authored-by: Ole André Vadla Ravnås <oleavr@gmail.com>
oleavr
force-pushed
the
unzip-gadget-files-android
branch
from
7c21c4c to
d6a0502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, when apps have
extractNativeLibsset tofalse, theconfiguration and potentially script files for frida-gadget are not
extracted and cannot be read using
FileUtils.