Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit package creator: use React dialogue to confirm exitting if changes have been done #2

Open
cpina opened this issue Oct 27, 2020 · 0 comments
Open

Exit package creator: use React dialogue to confirm exitting if changes have been done #2

cpina opened this issue Oct 27, 2020 · 0 comments
Labels
react tech-debt

Comments

@cpina
Copy link
Collaborator

cpina commented Oct 27, 2020

Steps to reproduce:

  • Login as a manager to schema-collaboration
  • On a datapackage click on Options -> Edit datapackage
  • Make changes (e.g. change the name of the datapackage)
  • Click on "Save to Server"
  • Make changes (e.g. change the name again)
  • Click on "Exit datapackage creator"

A dialogue will appear that reads: "If you continue you will lose the changes in this session" [Ok, Cancel]

This dialogue is a "confirm" in Javascript. It should be some nicer dialogue in React.
@cpina cpina changed the title Exit package creator: improve dialogue to confirm exitting if no changes have been done Exit package creator: use React dialogue to confirm exitting if changes have been done Oct 27, 2020
@cpina cpina mentioned this issue Oct 27, 2020
Open
@cpina cpina added the react label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
react tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cpina