Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebranding of resource label k8slens-edit-resource-version #141

Closed
dex4er opened this issue Feb 12, 2025 · 3 comments · Fixed by #142
Closed

Rebranding of resource label k8slens-edit-resource-version #141

dex4er opened this issue Feb 12, 2025 · 3 comments · Fixed by #142
Labels
enhancement New feature or request rebranding
Milestone

Comments

@dex4er
Copy link
Collaborator

dex4er commented Feb 12, 2025

Describe the bug
After editing any resource the label k8slens-edit-resource-version is added. It should be rebranded as well.

Maybe we should also use annotation rather than label to not break other IaC tools (Terraform, Flux).

To Reproduce
Steps to reproduce the behavior:

  1. Go to any resource
  2. Edit/Save
  3. New label appears
@dex4er dex4er added bug Something isn't working rebranding enhancement New feature or request and removed bug Something isn't working labels Feb 12, 2025
@robertobandini
Copy link
Member

robertobandini commented Feb 12, 2025

I'm wondering if to put this info could be an option that you can enable or not on Freelens... what do you think?

@dex4er
Copy link
Collaborator Author

dex4er commented Feb 12, 2025

I see Freelens uses this to check if the edit is already applied.

It is preferred to use annotation for it rather than label, as it is used ie. as deployment.kubernetes.io/revision annotation already.

Image

@dex4er
Copy link
Collaborator Author

dex4er commented Feb 12, 2025

Now looks even nicer:

Image

and ofc does not cause drift for Terraform, etc.

@dex4er dex4er added this to the v1.0.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rebranding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants