feat(favorites): modifying pray-and-pay ranking algorithm #5186
+44
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Not sure why the test is failing. I'd appreciate another set of eyes on it. |
…-anne/courtlistener into pray-and-pay-ranking-algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on a discussion related to the pray-and-pay ranking algorithm in #5111. The existing algorithm takes the geometric mean of the number of requests for a document and the average age of those requests. The way the code is currently written, the average age is always measured in seconds. That means for almost all documents, average age >>> number of requests, so a very old request will outweigh multiple recent requests for a different document.
To resolve this issue, the new algorithm first sorts by the number of requests for a document, and then breaks ties by sorting by number of views a particular docket (not document) has.