Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opinions): use default style for buttons in new case law ui #5165

Merged
merged 11 commits into from
Mar 11, 2025

Conversation

quevon24
Copy link
Member

  • use default style for buttons in new case law ui
  • remove unused styles

image

@quevon24 quevon24 linked an issue Feb 28, 2025 that may be closed by this pull request
@quevon24 quevon24 requested a review from flooie March 4, 2025 16:52
@flooie
Copy link
Contributor

flooie commented Mar 6, 2025

we should probably standardize these drop-downs

its strange that I didnt do that before but can you make both the same in style

Screenshot 2025-03-06 at 1 58 26 PM Screenshot 2025-03-06 at 1 58 29 PM

@quevon24
Copy link
Member Author

quevon24 commented Mar 6, 2025

we should probably standardize these drop-downs

its strange that I didnt do that before but can you make both the same in style

Screenshot 2025-03-06 at 1 58 26 PM Screenshot 2025-03-06 at 1 58 29 PM

Which option of the two dropdown do you like more?

@mlissner
Copy link
Member

mlissner commented Mar 6, 2025

What standardization are you looking for, Bill? One is a button with a drop down, the other is a button drop down. Different things?

@flooie
Copy link
Contributor

flooie commented Mar 7, 2025

@mlissner they do the same thing - the dropdown a button to click on. If I'm the only one it bothers thats fine. But I feel like they should both look the same. I prefer the separator @quevon24 personally.

@quevon24
Copy link
Member Author

quevon24 commented Mar 7, 2025

I think the main reason for having two different buttons is because on the first button with dropdown, if you click on "Get Citation Alerts" it will show a modal, but if you open the dropdown, you can see an option that takes you to the alerts help page.

In the second button, we can have multiple options to download (harvard pdf, a file from different source), so we cant perform an action if we had a button + dropdown, because user needs to select which files want to download

@flooie flooie merged commit 668d237 into main Mar 11, 2025
15 checks passed
@flooie flooie deleted the 4779-serif-buttons-and-labels-are-off-brand branch March 11, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Serif buttons and labels are off-brand
3 participants