3652 Catch APIError on multi-search requests due to bad query syntax #3659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the errors in #3652 relate to queries with incorrect syntax.
I described in #3171 the cases that seem different.
The problem was that previously, when using the Search API, it returned these kinds of errors as a
RequestError
, which we caught and logged as a warning.The Multi-search API now raises an
APIError
instead with the messageFailed to parse query ...
To stop raising these errors on bad query syntax and to display this screen to users instead:

Now it catch the
APIError
and only log a warning if the message error isFailed to parse query ...
.APIError
not related to query parsing because some of the errors logged in Sentry appear to have valid queries. However, the error message in Sentry just shows:ApiError /
, so it's better to log an error with the full message so we can identify if there are additionalAPIErrors
that we should handle or fix.