Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Active users][Settings][Kebab] Add 'Auto assign subordinate ids' option #224

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

carma12
Copy link
Collaborator

@carma12 carma12 commented Dec 15, 2023

The 'Auto assign subordinate ids' option should assign a range of IDs to a given user.

@carma12 carma12 force-pushed the kebab-auto-assign-sub-ids-option branch 3 times, most recently from 29fa1bf to a90c098 Compare December 19, 2023 08:20
@carma12 carma12 force-pushed the kebab-auto-assign-sub-ids-option branch 7 times, most recently from 6607253 to f9e558c Compare January 12, 2024 12:18
Copy link
Member

@pvoborni pvoborni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR. The core stuff works. But see the 2 comments.

src/components/UserSettings.tsx Show resolved Hide resolved
src/services/rpc.ts Show resolved Hide resolved
@pvoborni pvoborni self-assigned this Jan 12, 2024
@carma12 carma12 force-pushed the kebab-auto-assign-sub-ids-option branch 3 times, most recently from 7a16c2e to 3c8039a Compare January 16, 2024 15:18
Copy link
Member

@pvoborni pvoborni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carma12 carma12 force-pushed the kebab-auto-assign-sub-ids-option branch from 3c8039a to 0c2ccbc Compare January 17, 2024 08:21
The 'Auto assign subordinate ids' option
should assign a range of IDs to a given
user.

Signed-off-by: Carla Martinez <carlmart@redhat.com>
@carma12 carma12 force-pushed the kebab-auto-assign-sub-ids-option branch from 0c2ccbc to 806c172 Compare January 17, 2024 08:27
@carma12 carma12 merged commit 2b98ce4 into freeipa:main Jan 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants