Issue 214 - User settings should show if the user is disabled #222
Conversation
| @@ -58,6 +60,8 @@ const ActiveUsersTabs = () => { | |||
| return <DataSpinner />; | |||
| } | |||
|
|
|||
| const disabled = userSettingsData.user.nsaccountlock; | |||
There was a problem hiding this comment.
It seems that this variable is always true for enabled and disabled users, so the lock icon is being shown for all users. Maybe this is related to the way the data is retrieved (not 100% sure though).
There was a problem hiding this comment.
Ok I originally built this on top of your kabob work. So I think we need to get your PR's merged first then this will start working correctly
There was a problem hiding this comment.
Ok, so maybe we can postpone the review of this one until all kebab PRs are merged.
There was a problem hiding this comment.
This is working now, so I'm resolving this conversation thread.
If a user is disabled then show a "locked" icon next tothe user name in the userSettings page fixes: freeipa#214 Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
mreynolds389
force-pushed
the
issue214-disabled-icon
branch
from
f5b06ed to
a27a120
Compare
|
@carma12 ok it's working now, please review... |
This was rebased and already had npm install done. I am using PF5 classes, so I'm not sure what issues you are running into. Please elaborate... |
| @@ -58,6 +60,8 @@ const ActiveUsersTabs = () => { | |||
| return <DataSpinner />; | |||
| } | |||
|
|
|||
| const disabled = userSettingsData.user.nsaccountlock; | |||
There was a problem hiding this comment.
This is working now, so I'm resolving this conversation thread.
Whew! You had me worried for a moment as I didn't see anything wrong with it :-) |
If a user is disabled then show a "locked" icon next to the user name in the userSettings page
fixes: #214