Fix inconsistent label attributes #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fieldId` should match with the `name` for the fields mentioned in the issue mentioned below. Fixes: freeipa#204 Signed-off-by: Carla Martinez <carlmart@redhat.com>
The buttons available in the 'Settings' page should also have its own independent `name`. This has been implemented using the following format: `<action>-<fieldName>[-<idx>]` Being `idx` >= 0 E.g.1: `add-krb-principal-alias` E.g.2: `remove-certificate-mapping-data-1` Signed-off-by: Carla Martinez <carlmart@redhat.com>
miskopo
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fieldIdparameter should match with thenamefor the fields mentioned in the issue mentioned below.The buttons available on the 'Settings' page should also have their own independent
name. This has been implemented using the following format:<action>-<fieldName>[-<idx>](Being
idx>= 0)E.g.1:
add-krb-principal-aliasE.g.2:
remove-certificate-mapping-data-1Fixes: #204