[Active users][Settings] Kebab options #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma12
force-pushed
the
active-users-settings-kebab
branch
2 times, most recently
from
96339fe to
b43f3cc
Compare
|
This PR containing the new 'User' parameters needs to be merged first before this one. |
carma12
force-pushed
the
active-users-settings-kebab
branch
from
83b6cf7 to
ba093d8
Compare
carma12
force-pushed
the
active-users-settings-kebab
branch
6 times, most recently
from
53928a5 to
939e172
Compare
carma12
force-pushed
the
active-users-settings-kebab
branch
from
939e172 to
7effe87
Compare
The 'Reset password' option should take the new password values associated to the user account. Signed-off-by: Carla Martinez <carlmart@redhat.com>
The 'Enable'/'Disable' option should change the status of a given user. For this solution, the `DisableEnableUsers` component has been adapted to perform the API calls needed. Signed-off-by: Carla Martinez <carlmart@redhat.com>
carma12
force-pushed
the
active-users-settings-kebab
branch
from
7effe87 to
c59bf3f
Compare
The 'Delete' option allows to remove a given user from its 'Settings' page. The solution has been adapted to the three user pages (Active, Stage, and Preserved). Signed-off-by: Carla Martinez <carlmart@redhat.com>
The 'Unlock' option should unlock a specific account when a user has exceeded the maximum amount of login attempts (6 according the global policy). Signed-off-by: Carla Martinez <carlmart@redhat.com>
After adding a new OTP Token, a QR code to configure the token must be generated. Thus, a React-compatible library to generate those QR codes need to be used in the project. The qrcode.react[1] library has been chosen by its effective way of create and customize QR codes. [1] - https://github.com/zpao/qrcode.react Signed-off-by: Carla Martinez <carlmart@redhat.com>
The 'Add OTP token' option creates a new OTP token associated to a specific user. The QR code has been generated using the qrcode.react[1] library. [1]- https://github.com/zpao/qrcode.react Signed-off-by: Carla Martinez <carlmart@redhat.com>
The 'Rebuild auto membership' option should apply any specified rule to a given user. Signed-off-by: Carla Martinez <carlmart@redhat.com>
The 'New certificate' option should create and associate a new certificate to a given user. Signed-off-by: Carla Martinez <carlmart@redhat.com>
The 'Auto assign subordinate ids' option should assign a range of IDs to a given user. Signed-off-by: Carla Martinez <carlmart@redhat.com>
carma12
force-pushed
the
active-users-settings-kebab
branch
from
c59bf3f to
240fab0
Compare
The 'Activate' option enables the account of a given user, moving it from the 'Stage users' to the 'Active users' page. This option is only accessible form the 'Stage useres' page. The solution has adapted the API call made. Instead of using a generalistic batch endpoint a new specific endpoint has been created: `useActivateUserMutation`. This is being used from the main page and the kebab options located in the 'Settings' page. Signed-off-by: Carla Martinez <carlmart@redhat.com>
carma12
force-pushed
the
active-users-settings-kebab
branch
from
735973b to
159dfac
Compare
The 'Stage' option allows to move a given user from 'Preserved' to 'Stage'. Signed-off-by: Carla Martinez <carlmart@redhat.com>
The 'Restore' options moves a given user from 'Preserved' to 'Active' state. The `RestorePreservedUsers` component has been optimized for simplification, removing the `ErrorModal` component and relying the output messages on the `Alert` one. Also, a new endpoint `useRestoreUserMutation` has been created to be used instead of the generalistic one (`useSimpleMutCommandMutation`). Signed-off-by: Carla Martinez <carlmart@redhat.com>
carma12
force-pushed
the
active-users-settings-kebab
branch
from
159dfac to
295fa10
Compare
|
Hi, thank for the PR. Regrettably, I think I will not be able to review this PR with its current size. 12 commits with 2600+ lines change is too much for one PR. I'd borrow: https://google.github.io/eng-practices/review/developer/small-cls.html for the reasoning(cl == pr in this case). It's already nicely split into multiple commits, so e.g., each action can be in on PR. |
|
This PR will be split into several PRs to make it easier to review. Setting the 'WIP' tag. |
|
Closing this PR as it will be resolved in the newly created PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The options associated with the dropdown options (for each user) have been implemented. Those are:
For 'Active users':
For 'Stage users':
For 'Preserved users':