[Active users][Settings][Account settings] Add functionality for Selectors #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma12
force-pushed
the
account-settings-selectors
branch
from
1c6b8fb to
20316ae
Compare
|
This PR depends on this one to be merged: #136 |
carma12
force-pushed
the
account-settings-selectors
branch
from
20316ae to
16af12e
Compare
pvoborni
requested changes
Aug 25, 2023
carma12
force-pushed
the
account-settings-selectors
branch
from
16af12e to
85b594d
Compare
|
I have updated the code with the suggested changes. Some comments were provided as well. |
carma12
force-pushed
the
account-settings-selectors
branch
from
85b594d to
c4a806b
Compare
|
Updated the code again with the last corrections. |
carma12
force-pushed
the
account-settings-selectors
branch
from
c4a806b to
973705b
Compare
|
Updated the code with the last corrections. |
The Select[1] components need to be adapted to take data from the metadata. This will be applied for the fields 'Radius proxy configuration' and 'External IdP configuration'. [1]- http://v4-archive.patternfly.org/v4/components/select Signed-off-by: Carla Martinez <carlmart@redhat.com>
carma12
force-pushed
the
account-settings-selectors
branch
from
973705b to
eb502b7
Compare
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Select[1] components has been adapted to take data from the metadata. This has been applied for the fields 'Radius proxy configuration' and 'External IdP configuration'.
[1]- http://v4-archive.patternfly.org/v4/components/select