Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "Data" suffix in rpc and useUserSettingsData #142

Closed
carma12 opened this issue Sep 1, 2023 · 1 comment
Closed

Remove the "Data" suffix in rpc and useUserSettingsData #142

carma12 opened this issue Sep 1, 2023 · 1 comment
Assignees
@mreynolds389
Labels
good first issue Good for newcomers

Comments

@carma12
Copy link
Collaborator

carma12 commented Sep 1, 2023

Maybe we don't need have "Data" suffix in the following files:

  • rpc.ts
  • useUserSettingsData.ts
    As it is a bit redundant (all is data). Keeping it is also ok.

Originally posted by @pvoborni in #138 (comment)
@carma12 carma12 added the good first issue Good for newcomers label Sep 1, 2023
@mreynolds389 mreynolds389 self-assigned this Oct 5, 2023
mreynolds389 added a commit to mreynolds389/freeipa-webui that referenced this issue Oct 5, 2023
@mreynolds389
Issue 142 - Remove the "Data" suffix from rpc
e848853 
Refactor names that end with Data as it's redundant.

relates: freeipa#142

Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
@mreynolds389 mreynolds389 mentioned this issue Oct 5, 2023
Merged
mreynolds389 added a commit to mreynolds389/freeipa-webui that referenced this issue Oct 5, 2023
@mreynolds389
Issue 142 - Remove the "Data" suffix from rpc
f0f5ab0 
Refactor names that end with Data as it's redundant.

relates: freeipa#142

Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
mreynolds389 added a commit to mreynolds389/freeipa-webui that referenced this issue Oct 18, 2023
@mreynolds389
Issue 142 - Remove the "Data" suffix from rpc
2d42441 
Refactor names that end with Data as it's redundant.

relates: freeipa#142

Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
mreynolds389 added a commit that referenced this issue Oct 19, 2023
@mreynolds389
Issue 142 - Remove the "Data" suffix from rpc
3d89fe1 
Refactor names that end with Data as it's redundant.

relates: #142

Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
@carma12
Copy link
Collaborator Author

carma12 commented Oct 23, 2023

Already merged in upstream.

@carma12 carma12 closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mreynolds389 mreynolds389

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mreynolds389 @carma12