Compatibility fix for PyCA cryptography 42.0.0 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryptography 42.0.0 introduced two new abstract properties `not_valid_before_utc` and `not_valid_after_utc`, which are non-naive UTC variants of the `not_valid_before` and `not_valid_after` properties. The old properties are deprecated. The change also modifies tests to handle the new `_utc` variants. Fixes: freeipa#345 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Previously it was using 3.9 - 3.11 and testing on f38 and 39. F39 was EOLd in November 2024. Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cryptography 42.0.0 introduced two new abstract properties
not_valid_before_utcandnot_valid_after_utc, which are non-naive UTC variants of thenot_valid_beforeandnot_valid_afterproperties.The old properties are deprecated. The change also modifies tests to handle the new
_utcvariants.Fixes: #345