Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Only run CI on branch or pull request events, but not twice. #959

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

almet
Copy link
Member

@almet almet commented Oct 17, 2024

The CI currently runs on both pull-requests and branch events. This is an attempt to only run on one or the other.

@almet
Copy link
Member Author

almet commented Oct 17, 2024

Hmm, this doesn't seem to do what I want, as it's still running twice. 🤔 (Keeping it open in case somebody has a better idea, will garbage collect in a few otherwise).

@almet almet force-pushed the ci-pr-xor-branch branch 2 times, most recently from 4d31ff6 to 2ba247e Compare October 28, 2024 23:33
@almet
Copy link
Member Author

almet commented Nov 10, 2024

This should be ready now for review!

@almet almet requested a review from apyrgio November 10, 2024 20:35
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@apyrgio
Copy link
Contributor

apyrgio commented Nov 20, 2024

Thanks, the changes look good. Let's merge!

Previously, the actions were duplicated, due to the fact when developing
we often create feature branches and open pull requests.

This new setup requires us to open pull requests to trigger the CI.
@almet almet merged commit 630083b into main Nov 20, 2024
48 checks passed
@almet almet deleted the ci-pr-xor-branch branch November 20, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants