ch-#158617482 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix your travis failing tests |
zeze111
suggested changes
Jun 26, 2018
| @@ -7,7 +7,7 @@ import express from 'express'; | |||
| const Middleware = (app) => { | |||
| app.use(bodyParser.json()); | |||
| //public the view | |||
| app.use(express.static('View')); | |||
| //app.use(express.static('View')); | |||
There was a problem hiding this comment.
please delete commented code if you no longer need it, don't push commented code online
| export default blowFish; |
| return encrypted += decipher.final('base64'); | ||
| } | ||
| const blowFish = (text, key) => { | ||
| const decipher = crypto.createCipheriv('bf-cbc', key, 'ridewayway'); |
| }); | ||
| res.json(req.body.id); | ||
| } | ||
| }); |
There was a problem hiding this comment.
separate your routes from your methods, have a routes file, and a controllers folder contains the methods for your routes
| // delete a ride | ||
| ride.delete('/rides/:id', (req, res) => { | ||
| console.log(req.params.id); | ||
| res.json({ type: 'DELETE' }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
please refer to my comment concerning routes and controllers
| res.send({type: 'DELETE'}); | ||
| // delete a user | ||
| user.delete('/users/:id', (req, res) => { | ||
| res.json({ type: 'DELETE' }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
please refer to my comment concerning routes and controllers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#158617482- remodeling the code base to follow the proper guidelines given, so as to avoid unwanted bugs