Implement single factor authentication flow on 2fa-enabled iCloud accounts #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounts. This permits access without 2FA to some account information and the find my service only.
…mise to allow overriding options passed to iCloud service constructor; test/findmy now uses pause2FA single factor auth flow.
Instead of uncaught json parse exception, more gracefully handle and log authentication timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for single-factor authentication on iCloud accounts with 2FA enabled which permits access to find my services without completing 2fa flow.
Implement single-factor authentication flow on 2FA-enabled iCloud accounts
Adds a new single-factor authentication flow that allows access to the Find My service and some account information without requiring full 2FA completion.
Refactor test/authenticate and update Find My tests
Refactors the test/authenticate module to export a reusable authenticate function, allowing for customizable options to be passed to the iCloud service constructor. Updates test/findmy to utilize the new pause2FA single-factor authentication flow. Preserved REPL entry on direct execution of the authentication script,
Improve error handling and logging for Find My service
Instead of throwing uncaught json parse error on authentication timeout, more gracefully log and throw more meaningful exception.