mcap-play: Play at wall speed #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jtbandes I've incorporated the rate setting back into this PR. In my testing I was confused because the messages are following the desired rate but since we don't use this setting to control the "clock" time in studio, it was still updating my fixed-window plots at wall time. I think this is good to go in its current form. We can do a separate PR for clock support. |
jtbandes
approved these changes
Jan 16, 2024
jtbandes
added a commit
that referenced
this pull request
Jan 31, 2024
### Public-Facing Changes Fixed: `mcap-play` now plays at the correct speed instead of sending messages as fast as possible (#631)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
mcap-playnow attempts to play messages usinglog_timeagainst the wall clock. Previously it was playing messages as fast as possible regardless of thelog_timebetween messages.