mcap-record: Fix race condition when adding messages #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
reviewed
Nov 22, 2023
| data: new Uint8Array(event.data.buffer, event.data.byteOffset, event.data.byteLength), | ||
| }); | ||
|
|
||
| // If we can't acquire the lock, we will drop the message to avoid potential OOM issues. |
There was a problem hiding this comment.
Maybe we could have a setting for this? It could be useful in some situations to record everything even if it takes longer than realtime. We should make sure that after ^C the writer still gets closed cleanly — ideally finishing everything that was in the write queue already
jtbandes
reviewed
Nov 22, 2023
|
@jtbandes ping |
jtbandes
approved these changes
Nov 27, 2023
achim-k
deleted the
achim/fg-5775-the-data-recorded-by-the-mcap-record-command-is-too-large
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
mcap-record: Fix race condition when adding messages
Description
Does not directly call
writer.addMessagein the websocket message handler but instead pushes it to a queue. This makes sure that we do not callwriter.addMessageconcurrently which could happen due to a certainaddMessagetaking longer when a chunk is ready to be compressed & written. This PR also allows to set the message queue size and to opt out of chunk compression.Fixes #592
Resolves FG-5775