Update reader's emHeader method to return whether it read a sentinelHeader #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
approved these changes
Feb 28, 2024
snosenzo
added a commit
to foxglove/omgidl
that referenced
this pull request
Feb 29, 2024
Absent fields in structs do not write emHeaders, so the reading of the emHeader for the field will either return a future field's emHeader or a sentinelHeader. To allow for this, our reader stores the emHeader it reads for absent members and keeps them until it reads a field that is present or the struct ends. Depends on: foxglove/cdr#24 In this PR, we only return `undefined` for these fields, however the XCDR spec states that non-optional members should return default values for their types specified here: <img width="580" alt="image" src="https://github.com/foxglove/omgidl/assets/10187776/be2b8d00-c6d9-47a4-b357-03cbd17dbcca"> In the spirit of incremental delivery, this will be a followup PR and ticket. Addresses: FG-6436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to better support optional members of aggregated types in XCDR.
Related: FG-6436